Disable TSO for all Realtek controllers. Experimentation showed

RTL8111C generated corrupted frames where TCP option header was
broken. All other sample controllers I have did not show such
problem so it could be RTL8111C specific issue. Because there are
too many variants it's hard to tell how many controllers have such
issue. Just disable TSO by default but have user override it.

This commit is contained in:

Pyun YongHyeon

2011-01-25 19:05:46 +00:00

parent 9b61837ada

commit f9ad4da76d

1 changed files with 5 additions and 7 deletions

									
										sys/dev/re/if_re.c
									
		+5
		-7
	
												View File
												
				@@ -1504,14 +1504,12 @@ re_attach(device_t dev)

						ifp->if_capabilities |= IFCAP_WOL;

					ifp->if_capenable = ifp->if_capabilities;

					/*

					 * Don't enable TSO by default for old controllers. Under

					 * certain circumtances the controller generated corrupted

					 * packets in TSO size.

					 * Don't enable TSO by default.  It is known to generate

					 * corrupted TCP segments(bad TCP options) under certain

					 * circumtances.

					 */

					if ((sc->rl_flags & RL_FLAG_DESCV2) == 0) {

						ifp->if_hwassist &= ~CSUM_TSO;

						ifp->if_capenable &= ~(IFCAP_TSO4 | IFCAP_VLAN_HWTSO);

					}

					ifp->if_hwassist &= ~CSUM_TSO;

					ifp->if_capenable &= ~(IFCAP_TSO4 | IFCAP_VLAN_HWTSO);

				#ifdef DEVICE_POLLING

					ifp->if_capabilities |= IFCAP_POLLING;

				#endif