sys: Mark ACL conversion routines as __result_use_check

Both acl_copy_oldacl_into_acl() and acl_copy_acl_into_oldacl() may fail
in some circumstances (e.g., acl.acl_cnt exceeding the capacity of
OLDACL_MAX_ENTRIES).  This change marks both routines with
__result_use_check, enforcing check for errors by the caller.

Suggested by:	markj
Reviewed by:	markj, emaste
Sponsored by:	The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D46254

This commit is contained in:

Pierre Pronchery

2024-08-09 19:37:38 +02:00

committed by

Ed Maste

parent bef079254f

commit ef9fc9609a

1 changed files with 2 additions and 2 deletions

									
										sys/sys/acl.h
									
		+2
		-2
	
												View File
												
				@@ -309,9 +309,9 @@ void			acl_nfs4_compute_inherited_acl(

							    const struct acl *parent_aclp,

							    struct acl *child_aclp, mode_t mode,

							    int file_owner_id, int is_directory);

				int			acl_copy_oldacl_into_acl(const struct oldacl *source,

				int __result_use_check	acl_copy_oldacl_into_acl(const struct oldacl *source,

							    struct acl *dest);

				int			acl_copy_acl_into_oldacl(const struct acl *source,

				int __result_use_check	acl_copy_acl_into_oldacl(const struct acl *source,

							    struct oldacl *dest);

				/*