KekenoBSD/src
3
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

inet_net_test: Use int to hold expected return values from inet_net_pton

Browse Source 
GCC warns about the sign mismatch in comparisons:

lib/libc/tests/net/inet_net_test.cc: In member function 'virtual void {anonymous}::atfu_tc_inet_net_inet4::body() const':
lib/libc/tests/net/inet_net_test.cc:86:17: error: comparison of integer expressions of different signedness: 'int' and 'const unsigned int' [-Werror=sign-compare]
   86 |                 ATF_REQUIRE_EQ(bits, addr.bits);
      |                 ^~~~~~~~~~~~~~
lib/libc/tests/net/inet_net_test.cc: In member function 'virtual void {anonymous}::atfu_tc_inet_net_inet6::body() const':
lib/libc/tests/net/inet_net_test.cc:205:17: error: comparison of integer expressions of different signedness: 'int' and 'const unsigned int' [-Werror=sign-compare]
  205 |                 ATF_REQUIRE_EQ(bits, addr.bits);
      |                 ^~~~~~~~~~~~~~

Fixes:		8f4a0d2f7b ("libc: Import OpenBSD's inet_net_{ntop,pton}")
This commit is contained in:
John Baldwin
2025-10-20 14:31:41 -04:00
parent a8e4399fc6
commit e1aeb58cbb
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/libc/tests/net/inet_net_test.cc
+2 -2
View File
@@ -50,7 +50,7 @@ ATF_TEST_CASE_BODY(inet_net_inet4)
struct test_addr {
std::string input;
unsigned bits;
int bits;
std::string output;
};
@@ -134,7 +134,7 @@ ATF_TEST_CASE_BODY(inet_net_inet6)
struct test_addr {
std::string input;
unsigned bits;
int bits;
std::string output;
};