Don't return -10000 as the probe priority. That's lower than what
BUS_PROBE_HOOVER is. Drivers like proto(4), when compiled into the kernel or preloaded, will render your system useless by virtue of attaching to your PCI busses. Return BUS_PROBE_GENERIC instead. It's just the next priority up from BUS_PROBE_HOOVER. No other meaning has been give to its use. While BUS_PROBE_DEFAULT seems like a better candidate, it's hard not to think that there must be some reason why these drivers return -10000 in the first place. Differential Revision: D2705
This commit is contained in:
@@ -100,7 +100,7 @@ eisab_probe(device_t dev)
|
||||
|
||||
if (matched) {
|
||||
device_set_desc(dev, "PCI-EISA bridge");
|
||||
return(-10000);
|
||||
return (BUS_PROBE_GENERIC);
|
||||
}
|
||||
return(ENXIO);
|
||||
}
|
||||
|
||||
@@ -63,7 +63,7 @@ pci_hostb_probe(device_t dev)
|
||||
pci_get_subclass(dev) == PCIS_BRIDGE_HOST) {
|
||||
device_set_desc(dev, "Host to PCI bridge");
|
||||
device_quiet(dev);
|
||||
return (-10000);
|
||||
return (BUS_PROBE_GENERIC);
|
||||
}
|
||||
return (ENXIO);
|
||||
}
|
||||
|
||||
@@ -66,7 +66,7 @@ ignore_pci_probe(device_t dev)
|
||||
case 0x10001042ul: /* SMC 37C665 */
|
||||
device_set_desc(dev, "ignored");
|
||||
device_quiet(dev);
|
||||
return(-10000);
|
||||
return (BUS_PROBE_GENERIC);
|
||||
}
|
||||
return(ENXIO);
|
||||
}
|
||||
|
||||
@@ -154,7 +154,7 @@ isab_pci_probe(device_t dev)
|
||||
|
||||
if (matched) {
|
||||
device_set_desc(dev, "PCI-ISA bridge");
|
||||
return(-10000);
|
||||
return (BUS_PROBE_GENERIC);
|
||||
}
|
||||
return(ENXIO);
|
||||
}
|
||||
|
||||
@@ -890,7 +890,7 @@ pcib_probe(device_t dev)
|
||||
if ((pci_get_class(dev) == PCIC_BRIDGE) &&
|
||||
(pci_get_subclass(dev) == PCIS_BRIDGE_PCI)) {
|
||||
device_set_desc(dev, "PCI-PCI bridge");
|
||||
return(-10000);
|
||||
return (BUS_PROBE_GENERIC);
|
||||
}
|
||||
return(ENXIO);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user