Don't check for ifp != NULL before KASSERT, as ifp may not be NULL here

(it is dereferenced below).

Discussed with:	jhb
MFC after:	1 week

This commit is contained in:

Mikolaj Golub

2012-07-03 19:04:18 +00:00

parent 3a288e901f

commit b7d61ba317

1 changed files with 5 additions and 7 deletions

									
										sys/netinet/igmp.c
									
		+5
		-7
	
												View File
												
				@@ -2285,13 +2285,11 @@ igmp_change_state(struct in_multi *inm)

					 */

					KASSERT(inm->inm_ifma != NULL, ("%s: no ifma", __func__));

					ifp = inm->inm_ifma->ifma_ifp;

					if (ifp != NULL) {

						/*

						 * Sanity check that netinet's notion of ifp is the

						 * same as net's.

						 */

						KASSERT(inm->inm_ifp == ifp, ("%s: bad ifp", __func__));

					}

					/*

					 * Sanity check that netinet's notion of ifp is the

					 * same as net's.

					 */

					KASSERT(inm->inm_ifp == ifp, ("%s: bad ifp", __func__));

					IGMP_LOCK();