ip_mroute: handle V_mfchashtbl allocation failure

We allocate V_mfchashtbl with HASH_NOWAIT (which maps to M_NOWAIT), so
this allocation may fail. As we didn't handle that failure we could end
up dereferencing a NULL pointer later (e.g. during X_ip_mrouter_done()).

Do the obvious thing and fail out if we cannot allocate the table.

See also:	https://redmine.pfsense.org/issues/14917
Sponsored by:	Rubicon Communications, LLC ("Netgate")

This commit is contained in:

Kristof Provost

2023-11-22 14:44:03 +01:00

parent 8ec79e8ae0

commit b01cad6d3a

1 changed files with 4 additions and 0 deletions

									
										sys/netinet/ip_mroute.c
									
		+4
		
												View File
												
				@@ -708,6 +708,10 @@ ip_mrouter_init(struct socket *so, int version)

					V_mfchashtbl = hashinit_flags(mfchashsize, M_MRTABLE, &V_mfchash,

					    HASH_NOWAIT);

					if (V_mfchashtbl == NULL) {

						MRW_WUNLOCK();

						return (ENOMEM);

					}

					/* Create upcall ring */

					mtx_init(&V_bw_upcalls_ring_mtx, "mroute upcall buf_ring mtx", NULL, MTX_DEF);