KekenoBSD/src
3
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

ice(4): Handle allmulti flag in ice_if_promisc_set function

Browse Source 
In the ice_if_promisc_set function, the driver currently disables the
IFF_ALLMULTI flag, thereby preventing the activation of multicast mode.
To address this issue, implement appropriate handling to ensure the
flag is managed correctly.

Signed-off-by: Yogesh Bhosale <yogesh.bhosale@intel.com>

Tested by:	Gowthamkumar K S <gowtham.kumar.ks@intel.com>
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D54186
This commit is contained in:
Yogesh Bhosale
2026-02-01 10:27:36 -07:00
committed by Kevin Bowling
parent cea2683bb6
commit 98bdf63f6e
1 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sys/dev/ice/if_ice_iflib.c
+20 -5
View File
@@ -1907,15 +1907,13 @@ ice_if_promisc_set(if_ctx_t ctx, int flags)
ice_set_default_promisc_mask(promisc_mask);
if (multi_enable)
return (EOPNOTSUPP);
if (promisc_enable) {
status = ice_set_vsi_promisc(hw, sc->pf_vsi.idx,
promisc_mask, 0);
if (status && status != ICE_ERR_ALREADY_EXISTS) {
device_printf(dev,
"Failed to enable promiscuous mode for PF VSI, err %s aq_err %s\n",
"Failed to enable promiscuous mode for "
"PF VSI, err %s aq_err %s\n",
ice_status_str(status),
ice_aq_str(hw->adminq.sq_last_status));
return (EIO);
@@ -1925,11 +1923,28 @@ ice_if_promisc_set(if_ctx_t ctx, int flags)
promisc_mask, 0);
if (status) {
device_printf(dev,
"Failed to disable promiscuous mode for PF VSI, err %s aq_err %s\n",
"Failed to disable promiscuous mode for"
" PF VSI, err %s aq_err %s\n",
ice_status_str(status),
ice_aq_str(hw->adminq.sq_last_status));
return (EIO);
}
if (multi_enable) {
ice_clear_bit(ICE_PROMISC_UCAST_TX, promisc_mask);
ice_clear_bit(ICE_PROMISC_UCAST_RX, promisc_mask);
status = ice_set_vsi_promisc(hw, sc->pf_vsi.idx,
promisc_mask, 0);
if (status && status != ICE_ERR_ALREADY_EXISTS) {
device_printf(dev,
"Failed to enable allmulti mode "
"for PF VSI, err %s aq_err %s\n",
ice_status_str(status),
ice_aq_str(
hw->adminq.sq_last_status));
return (EIO);
}
}
}
return (0);