acpi_panasonic: acquire serial lock before calling hkey_sound_mute in shutdown
acpi_panasonic_shutdown() calls hkey_sound_mute() without holding the ACPI serial lock. Every other call site holds `ACPI_SERIAL_BEGIN(panasonic)` before calling it, as the locking model is caller-owned. This seems to affect the whole Panasonic Toughtbook lineup btw. Reviewed by: ngie Differential Revision: https://reviews.freebsd.org/D56718
This commit is contained in:
committed by
Enji Cooper
parent
fd386e76fa
commit
7619d14d08
@@ -233,7 +233,9 @@ acpi_panasonic_shutdown(device_t dev)
|
||||
/* Mute the main audio during reboot to prevent static burst to speaker. */
|
||||
sc = device_get_softc(dev);
|
||||
mute = 1;
|
||||
ACPI_SERIAL_BEGIN(panasonic);
|
||||
hkey_sound_mute(sc->handle, HKEY_SET, &mute);
|
||||
ACPI_SERIAL_END(panasonic);
|
||||
return (0);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user