smartpqi: Avoid declaring extern inline functions
Each C file is compiled separately so these functions can't be inlined
except in the file where they are defined. Since these functions aren't
used outside smartpqi_request.c, just do the simple thing and make them
private to that file.
Reported by: gcc
Reviewed by: jrhall
Fixes: c558eca479 ("smartpqi: update to version 4660.0.2002")
Differential Revision: https://reviews.freebsd.org/D54732
This commit is contained in:
@@ -167,10 +167,6 @@ int pqisrc_send_tmf(pqisrc_softstate_t *, pqi_scsi_dev_t const *,
|
||||
rcb_t *, rcb_t *, int);
|
||||
int pqisrc_write_current_time_to_host_wellness(pqisrc_softstate_t *softs);
|
||||
int pqisrc_write_driver_version_to_host_wellness(pqisrc_softstate_t *softs);
|
||||
extern inline void pqisrc_aio_build_cdb(aio_req_locator_t *, uint32_t,
|
||||
rcb_t *, uint8_t *);
|
||||
extern inline boolean_t pqisrc_aio_req_too_big(pqisrc_softstate_t *, pqi_scsi_dev_t *,
|
||||
rcb_t const *, aio_req_locator_t *, uint32_t);
|
||||
void pqisrc_build_aio_common(pqisrc_softstate_t *, pqi_aio_req_t *,
|
||||
rcb_t *, uint32_t);
|
||||
void pqisrc_build_aio_R1_write(pqisrc_softstate_t *,
|
||||
|
||||
@@ -1492,7 +1492,7 @@ pqisrc_handle_blk_size_diffs(aio_req_locator_t *l)
|
||||
* handle based on dev type, Raid level, and encryption status.
|
||||
* TODO: make limits dynamic when this becomes possible.
|
||||
*/
|
||||
inline boolean_t
|
||||
static boolean_t
|
||||
pqisrc_aio_req_too_big(pqisrc_softstate_t *softs,
|
||||
pqi_scsi_dev_t *device, rcb_t const *rcb,
|
||||
aio_req_locator_t *l, uint32_t disk_blk_cnt)
|
||||
@@ -1636,7 +1636,7 @@ pqisrc_aio_show_locator_info(pqisrc_softstate_t *softs,
|
||||
}
|
||||
|
||||
/* build the aio cdb */
|
||||
inline void
|
||||
static void
|
||||
pqisrc_aio_build_cdb(aio_req_locator_t *l,
|
||||
uint32_t disk_blk_cnt, rcb_t *rcb, uint8_t *cdb)
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user