Revision 1.61 changed the allocation of buffer 'buf' in DoFile() from

the stack to the heap to work around a problem on ia64. Now, roughly
16 months and two compiler updates later, it isn't an issue anymore
in the sense that putting a 1M buffer on the stack just works and we
don't actually need to work around anything anymore.
However, since there's no advantage or need to put the buffer on the
stack (again), this change merely removes the XXX comment describing
that there's an explicit reason for the heap allocation. Hence, this
change is a functional no-op.

PR: ia64/38677

This commit is contained in:

Marcel Moolenaar

2003-10-08 07:37:11 +00:00

parent 28cd624700

commit 4b290df1dd

1 changed files with 0 additions and 6 deletions

									
										sbin/savecore/savecore.c
									
		-6
	
												View File
												
				@@ -221,12 +221,6 @@ DoFile(char *savedir, const char *device)

					dmpcnt = 0;

					mediasize = 0;

					/*

					 * XXX On ia64 something breaks when the buffer is put on the

					 * stack. When the buffer is roughly larger than 128K the read()

					 * below simply fails with errno=14 (EFAULT). We work around

					 * this by doing a one-time allocation...

					 */

					if (buf == NULL) {

						buf = malloc(BUFFERSIZE);

						if (buf == NULL) {