KekenoBSD/src
3
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

e1000: Don't enable ASPM L1 without L0s

Browse Source 
Reporter noted packet loss with 82583.  NVM is down level.  The
errata docs mention disabling this, which should be the firmware
default, so I am not sure why we were enabling this bit.  Linux and
OpenBSD have the same issue, while NetBSD got it right.

Reported by:	Codin <codin@nagi.ftp.sh>
Tested by:	Codin <codin@nagi.ftp.sh>
MFC after:	2 weeks
This commit is contained in:
Kevin Bowling
2025-11-20 22:47:03 -07:00
parent aa30bab9a9
commit 2ead091715
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sys/dev/e1000/e1000_82571.c
+2 -1
View File
@@ -1118,7 +1118,8 @@ static s32 e1000_init_hw_82571(struct e1000_hw *hw)
case e1000_82574:
case e1000_82583:
reg_data = E1000_READ_REG(hw, E1000_GCR);
reg_data |= E1000_GCR_L1_ACT_WITHOUT_L0S_RX;
/* 82574 Errata 25, 82583 Errata 12 */
reg_data &= ~E1000_GCR_L1_ACT_WITHOUT_L0S_RX;
E1000_WRITE_REG(hw, E1000_GCR, reg_data);
break;
default: