Ed Schouten
4ef9bd22ed
Improve typing of POSIX search tree functions.
...
Back in 2015 when I reimplemented these functions to use an AVL tree, I
was annoyed by the weakness of the typing of these functions. Both tree
nodes and keys are represented by 'void *', meaning that things like the
documentation for these functions are an absolute train wreck.
To make things worse, users of these functions need to cast the return
value of tfind()/tsearch() from 'void *' to 'type_of_key **' in order to
access the key. Technically speaking such casts violate aliasing rules.
I've observed actual breakages as a result of this by enabling features
like LTO.
I've filed a bug report at the Austin Group. Looking at the way the bug
got resolved, they made a pretty good step in the right direction. A new
type 'posix_tnode' has been added to correspond to tree nodes. It is
still defined as 'void' for source-level compatibility, but in the very
far future it could be replaced by a proper structure type containing a
key pointer.
MFC after: 1 month
Differential Revision: https://reviews.freebsd.org/D8205
2016-10-13 18:25:40 +00:00
..
2016-09-01 02:42:11 +00:00
2016-08-31 19:30:46 +00:00
2016-08-12 01:05:07 +00:00
2016-02-04 21:16:35 +00:00
2016-02-05 01:03:38 +00:00
2016-10-04 11:56:46 +00:00
2016-02-04 21:16:35 +00:00
2016-02-04 21:16:35 +00:00
2016-06-03 19:25:30 +00:00
2016-02-04 21:16:35 +00:00
2016-05-04 22:34:11 +00:00
2016-05-16 15:42:59 +00:00
2016-02-04 21:16:35 +00:00
2016-05-13 21:17:49 +00:00
2016-02-04 21:16:35 +00:00
2016-10-13 18:25:40 +00:00
2015-06-13 19:20:56 +00:00
2016-08-31 00:11:35 +00:00
2016-02-04 21:16:35 +00:00
2016-05-24 00:57:11 +00:00
2016-10-05 20:02:34 +00:00
2016-10-05 16:23:02 +00:00
2016-06-14 16:55:05 +00:00
2016-02-04 21:16:35 +00:00
2016-05-25 07:26:22 +00:00
2016-09-27 18:55:45 +00:00
2016-08-10 15:16:28 +00:00
2016-04-26 01:20:16 +00:00
2016-06-29 11:48:42 +00:00
2016-08-29 22:48:36 +00:00
2016-06-03 19:25:30 +00:00
2016-04-04 23:55:32 +00:00
2016-02-04 21:16:35 +00:00
2016-03-02 16:14:46 +00:00
2016-04-21 12:58:29 +00:00
2016-09-24 15:11:27 +00:00
2016-10-13 06:56:23 +00:00
2016-04-21 12:58:29 +00:00
2016-08-31 15:05:04 +00:00
2016-02-04 21:16:35 +00:00
2016-08-12 01:05:07 +00:00
2016-02-04 21:16:35 +00:00
2016-05-31 08:27:39 +00:00
2016-03-02 16:14:46 +00:00
2016-02-04 21:16:35 +00:00
2016-04-19 15:18:31 +00:00
2016-05-01 19:37:33 +00:00
2015-11-25 19:10:28 +00:00
2016-09-11 17:44:35 +00:00
2016-04-18 15:08:31 +00:00
2016-10-02 11:56:17 +00:00
2016-05-01 19:37:33 +00:00
2016-07-18 01:55:25 +00:00
2016-02-04 21:16:35 +00:00
2016-02-04 21:16:35 +00:00
2016-06-27 06:41:11 +00:00
2016-07-21 18:47:51 +00:00
2016-02-10 04:20:39 +00:00
2016-03-02 16:14:46 +00:00
2016-05-12 03:53:20 +00:00
2016-05-20 19:30:52 +00:00
2016-02-04 21:16:35 +00:00
2016-02-04 21:16:35 +00:00
2016-02-04 21:16:35 +00:00
2016-02-04 21:16:35 +00:00
2016-08-27 13:40:27 +00:00
2016-02-04 21:16:35 +00:00
2016-02-04 21:16:35 +00:00
2016-08-22 20:48:46 +00:00
2016-08-09 19:44:33 +00:00
2016-02-16 02:14:30 +00:00
2016-03-02 16:14:46 +00:00
2016-05-01 19:37:33 +00:00
2016-08-31 19:30:46 +00:00
2016-09-24 15:11:27 +00:00
2016-05-24 11:44:43 +00:00
2016-05-11 14:37:33 +00:00
2016-03-02 16:14:46 +00:00
2016-09-30 19:59:56 +00:00
2016-10-02 17:02:59 +00:00
2016-08-31 19:30:46 +00:00
2016-02-04 21:16:35 +00:00
2016-05-01 19:37:33 +00:00
2016-03-02 16:14:46 +00:00
2016-02-04 21:16:35 +00:00
2016-03-02 16:14:46 +00:00
2016-03-02 16:14:46 +00:00
2016-02-04 21:16:35 +00:00
2016-10-03 14:07:15 +00:00
2016-02-04 21:16:35 +00:00
2016-02-04 21:16:35 +00:00
2016-08-12 19:31:41 +00:00
2016-02-04 21:16:35 +00:00
2016-02-04 21:16:35 +00:00
2016-09-24 15:11:27 +00:00
2016-02-04 21:16:35 +00:00
2016-06-04 14:57:25 +00:00
2016-05-18 19:59:05 +00:00
2016-02-04 21:16:35 +00:00
2016-02-04 21:16:35 +00:00
2016-09-04 12:17:57 +00:00
2016-09-02 08:44:14 +00:00
2016-08-12 06:16:14 +00:00
2016-09-21 11:59:52 +00:00
2016-04-13 16:19:50 +00:00
2016-05-01 19:37:33 +00:00
2016-02-04 21:16:35 +00:00
2016-05-29 01:43:28 +00:00
2016-02-04 21:16:35 +00:00
2016-04-16 02:32:12 +00:00
2016-04-04 23:55:32 +00:00
2016-10-11 20:31:59 +00:00
2016-05-09 22:21:09 +00:00
2016-05-04 23:20:53 +00:00
2016-10-13 06:56:23 +00:00