libpfctl: fix memory leak

Browse Source

When we snl_init_writer() we allocate memory in the struct snl_state in the struct pfctl_handle.
This memory was never released again, leading to a memory leak. We still
had a reference to the memory and would release it on pfctl_close()
(so valgrind did not detect it as a leak), but long-lived users (e.g.
bsnmpd) would eventually run out of memory.

Explicitly reset the snl_state when we're done to prevent this.

MFC after:	2 weeks
Sponsored by:	Rubicon Communications, LLC ("Netgate")

...

This commit is contained in:

Kristof Provost

2026-06-11 16:58:20 +02:00

parent 2a478dfc7f

commit fcb31b5711

1 changed files with 428 additions and 171 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

lib/libpfctl/libpfctl.c

+428 -171

File diff suppressed because it is too large Load Diff