KekenoBSD/src
3
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

mwl: return ENOMEM when rx buffer allocation fails
Cross-build Kernel / amd64 ubuntu-22.04 (clang-15) (push) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-22.04 (clang-15) (push) Has been cancelled
Details
Cross-build Kernel / amd64 ubuntu-24.04 (clang-18) (push) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-24.04 (clang-18) (push) Has been cancelled
Details
Cross-build Kernel / amd64 macos-latest (clang-18) (push) Has been cancelled
Details
Cross-build Kernel / aarch64 macos-latest (clang-18) (push) Has been cancelled
Details

Browse Source 
The malloc() failure path returned error, which is 0 at this point,
so callers would treat the allocation failure as success.
Return ENOMEM instead to correctly propagate the out-of-memory condition.

Reviewed by:	adrian
Differential Revision:	https://reviews.freebsd.org/D42282
This commit is contained in:
Kevin Lo
2026-06-15 09:43:57 +08:00
parent db887713de
commit fa75c1cc24
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sys/dev/mwl/if_mwl.c
+1 -1
View File
@@ -2165,7 +2165,7 @@ mwl_rxdma_setup(struct mwl_softc *sc)
bf = malloc(bsize, M_MWLDEV, M_NOWAIT | M_ZERO); bf = malloc(bsize, M_MWLDEV, M_NOWAIT | M_ZERO);
if (bf == NULL) { if (bf == NULL) {
device_printf(sc->sc_dev, "malloc of %u rx buffers failed\n", bsize); device_printf(sc->sc_dev, "malloc of %u rx buffers failed\n", bsize);
return error; return ENOMEM;
} }
sc->sc_rxdma.dd_bufptr = bf; sc->sc_rxdma.dd_bufptr = bf;