KekenoBSD/src
3
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

nvme: Improve error message for invalid format value

Browse Source 
Improve the wording of the invalid namespace value. Reword the comment
and move a line of code to the block it logically belongs to.

No functional changes intended.

Sponsored by:		Netflix
Differential Revision:	https://reviews.freebsd.org/D51393
This commit is contained in:
Warner Losh
2025-12-05 16:17:40 -07:00
parent c6212b7da1
commit f5b812331d
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sys/dev/nvme/nvme_ns.c
+5 -7
View File
@@ -563,16 +563,14 @@ nvme_ns_construct(struct nvme_namespace *ns, uint32_t id,
return ((ns->flags & NVME_NS_ADDED) ? 0 : ENXIO); return ((ns->flags & NVME_NS_ADDED) ? 0 : ENXIO);
} }
flbas_fmt = NVMEV(NVME_NS_DATA_FLBAS_FORMAT, ns->data.flbas);
/* /*
* Note: format is a 0-based value, so > is appropriate here, * Check the validity of the format specified. Note: format is a 0-based
* not >=. * value, so > is appropriate here, not >=.
*/ */
flbas_fmt = NVMEV(NVME_NS_DATA_FLBAS_FORMAT, ns->data.flbas);
if (flbas_fmt > ns->data.nlbaf) { if (flbas_fmt > ns->data.nlbaf) {
nvme_printf(ctrlr, nvme_printf(ctrlr, "nsid %d lba format %d invalid (> %d)\n",
"lba format %d exceeds number supported (%d)\n", id, flbas_fmt, ns->data.nlbaf + 1);
flbas_fmt, ns->data.nlbaf + 1);
return (ENXIO); return (ENXIO);
} }