From de0fcd3a4499408be6ead3db8d2982e65724217b Mon Sep 17 00:00:00 2001 From: Mateusz Guzik Date: Sat, 22 Aug 2020 16:58:59 +0000 Subject: [PATCH] vfs: assert that HASBUF is only set with SAVENAME or SAVESTART as requested by the caller. The intent is to eradicate the mostly spurious NDFREE_PNBUF calls. --- sys/kern/vfs_lookup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/kern/vfs_lookup.c b/sys/kern/vfs_lookup.c index c97db630888..e38b02e9652 100644 --- a/sys/kern/vfs_lookup.c +++ b/sys/kern/vfs_lookup.c @@ -1384,6 +1384,7 @@ NDFREE_PNBUF(struct nameidata *ndp) { if ((ndp->ni_cnd.cn_flags & HASBUF) != 0) { + MPASS((ndp->ni_cnd.cn_flags & (SAVENAME | SAVESTART)) != 0); uma_zfree(namei_zone, ndp->ni_cnd.cn_pnbuf); ndp->ni_cnd.cn_flags &= ~HASBUF; }