From d4083fb836cf5d06a2bc2d6fe7297fb5139c8fc6 Mon Sep 17 00:00:00 2001 From: Gleb Smirnoff Date: Wed, 4 Mar 2026 19:57:59 -0800 Subject: [PATCH] tests/net/bpf: hexdump(3) the packets if compare fails --- tests/sys/net/bpf/Makefile | 2 +- tests/sys/net/bpf/pcap-test.c | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/sys/net/bpf/Makefile b/tests/sys/net/bpf/Makefile index cee27b55043..62e04e5a970 100644 --- a/tests/sys/net/bpf/Makefile +++ b/tests/sys/net/bpf/Makefile @@ -10,7 +10,7 @@ LIBADD+= nv PROGS= bpf_multi_read pcap-test LIBADD.bpf_multi_read+= pcap CFLAGS.pcap-test.c+= -Wno-cast-align -LIBADD.pcap-test+= pcap +LIBADD.pcap-test+= pcap util ATF_TESTS_SH= bpf diff --git a/tests/sys/net/bpf/pcap-test.c b/tests/sys/net/bpf/pcap-test.c index 9d01548f7aa..4f837959208 100644 --- a/tests/sys/net/bpf/pcap-test.c +++ b/tests/sys/net/bpf/pcap-test.c @@ -31,6 +31,7 @@ #include #include #include +#include #include #include #include @@ -219,8 +220,11 @@ compare(int argc __unused, char *argv[]) if (p1->caplen != p2->caplen) errx(1, "packet #%u capture length %u != %u", cnt, p1->caplen, p2->caplen); - if (memcmp(p1->data, p2->data, p1->caplen) != 0) + if (memcmp(p1->data, p2->data, p1->caplen) != 0) { + hexdump(p1->data, p1->caplen, argv[0], 0); + hexdump(p2->data, p2->caplen, argv[1], 0); errx(1, "packet #%u payload different", cnt); + } } if (p1 != NULL || p2 != NULL) errx(1, "packet count different");