userland build: replace -fno-common with ${CFCOMMONFLAG}

This change allows any downstream or otherwise consumer to easily override
the new -fno-common default on a temporary basis without having to hack into
src.sys.mk, and also makes it a bit easier to search for these specific
cases where -fno-common must be overridden with -fcommon or else the build
will fail.

The gdb build, the only program requiring -fcommon on head/, is switched
over as an example usage. It will need it on all branches, so this does not
harm future mergability.

MFC after:	3 days

This commit is contained in:

Kyle Evans

2020-04-10 14:01:07 +00:00

parent 73129d4797

commit 879ce458f4

2 changed files with 3 additions and 2 deletions

									
										gnu/usr.bin/gdb/Makefile.inc
									
		+1
		-1
	
												View File
												
				@@ -50,7 +50,7 @@ CFLAGS+= -I${SYSROOT:U${DESTDIR}}/${INCLUDEDIR}/edit

				# Some bits here currently rely on some of the linker-merging magic that happens

				# with -fcommon.  While this is the default right now, explicitly set -fcommon

				# so that it continues to build when the default flips.

				CFLAGS+= -fcommon

				CFCOMMONFLAG= -fcommon

				GENSRCS+= nm.h tm.h