cam/mmc: Remove stray xpt_path_inq

Turns out, we don't use the results of xpt_path_inq here at all. And it
also causes problems. Since it calls xpt_cam_inq to do this useless
XPT_PATH_INQ, it loses the original priority we had for the CCB. This
priority should be CAM_PRIORITY_XPT, but was oringially set to
CAM_PRIORITY_NORMAL. This worked to enumerate the device because no
normal priority CCBs were queued by anything doing the
enumeration. However, when I changed xpt_path_inq to use the more proper
PRIORITY_NONE, it exposed this bug because queued CCBs with
PRIORITY_NONE sometimes won't run. This caused the probe device to stop
after its first operation. Removing the xpt_path_inq means we no longer
step on the important fields we get from xpt_schedule, allowing probing
to work correctly.

Noticed by: bz@
Sponsored by: Netflix

This commit is contained in:

Warner Losh

2025-07-21 20:50:50 -06:00

parent bd4a4e46ce

commit 73e1bd7142

1 changed files with 0 additions and 1 deletions

									
										sys/cam/mmc/mmc_xpt.c
									
		-1
	
												View File
												
				@@ -610,7 +610,6 @@ mmcprobe_start(struct cam_periph *periph, union ccb *start_ccb)

						CAM_DEBUG(start_ccb->ccb_h.path, CAM_DEBUG_PROBE, ("Start with PROBE_RESET\n"));

						/* FALLTHROUGH */

					case PROBE_IDENTIFY:

						xpt_path_inq(&start_ccb->cpi, periph->path);

						CAM_DEBUG(start_ccb->ccb_h.path, CAM_DEBUG_PROBE, ("Start with PROBE_IDENTIFY\n"));

						init_standard_ccb(start_ccb, XPT_MMC_GET_TRAN_SETTINGS);

						break;