From 67a63eae7b2d10d29983c9698894f1bfff4ffc6e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dag-Erling=20Sm=C3=B8rgrav?= <des@FreeBSD.org>
Date: Wed, 29 Apr 2026 17:14:13 +0200
Subject: [PATCH] bc: Fix tests

Stop generating test scripts at build time.  The dc test script is
broken and simply fixing the code that generates it won't help as there
is no reliable way to ensure it gets regenerated if it already exists in
the object tree.

MFC after:	1 week
Reviewed by:	se
Differential Revision:	https://reviews.freebsd.org/D56511
---
 tools/build/depend-cleanup.sh   |  4 ++++
 usr.bin/gh-bc/tests/Makefile    | 10 ----------
 usr.bin/gh-bc/tests/bc_tests.sh |  5 +++++
 usr.bin/gh-bc/tests/dc_tests.sh |  5 +++++
 4 files changed, 14 insertions(+), 10 deletions(-)
 create mode 100755 usr.bin/gh-bc/tests/bc_tests.sh
 create mode 100755 usr.bin/gh-bc/tests/dc_tests.sh

diff --git a/tools/build/depend-cleanup.sh b/tools/build/depend-cleanup.sh
index 1c9b7ea8c3b..b72dd3b60f0 100755
--- a/tools/build/depend-cleanup.sh
+++ b/tools/build/depend-cleanup.sh
@@ -317,6 +317,10 @@ check_epoch_and_opts
 #          "$OBJTOP"/tests/sys/kqueue/libkqueue/*
 #fi
 
+# 20260427 # bc / dc test scripts no longer generated
+dir="${OBJTOP%/}"/usr.bin/gh-bc/tests
+run rm -fv "${dir}"/bc_tests.sh "${dir}"/dc_tests.sh
+
 # 20260426 # libpkgconf contains incorrect paths
 clean_obj lib/libpkgconf personality c pkgconfig:/share
 clean_obj lib/libpkgconf pkg c pkgconfig:/share
diff --git a/usr.bin/gh-bc/tests/Makefile b/usr.bin/gh-bc/tests/Makefile
index f2c92aecb0a..6c3098350c5 100644
--- a/usr.bin/gh-bc/tests/Makefile
+++ b/usr.bin/gh-bc/tests/Makefile
@@ -55,14 +55,4 @@ FILESdc_scriptsMODE=	0755
 
 PLAIN_TESTS_SH=		bc_tests dc_tests
 
-bc_tests.sh:
-	echo "#!/bin/sh" > ${.TARGET}
-	echo 'env LANG=C BC_TEST_OUTPUT_DIR=$$(pwd) \
-		${TESTSDIR}/tests/all.sh -n bc 1 1 0 0 bc' >> ${.TARGET}
-
-dc_tests.sh:
-	echo "#!/bin/sh" > ${.TARGET}
-	echo "env LANG=C BC_TEST_OUTPUT_DIR=\$pwd \
-		${TESTSDIR}/tests/all.sh -n dc 1 1 0 0 dc" >> ${.TARGET}
-
 .include <bsd.test.mk>
diff --git a/usr.bin/gh-bc/tests/bc_tests.sh b/usr.bin/gh-bc/tests/bc_tests.sh
new file mode 100755
index 00000000000..76cfee05560
--- /dev/null
+++ b/usr.bin/gh-bc/tests/bc_tests.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+unset LC_ALL LC_CTYPE LC_MESSAGES LC_MONETARY LC_NUMERIC LC_TIME
+export LANG=C
+export BC_TEST_OUTPUT_DIR=${PWD}
+exec "$(dirname "$(realpath "$0")")"/tests/all.sh -n bc 1 1 0 0 bc
diff --git a/usr.bin/gh-bc/tests/dc_tests.sh b/usr.bin/gh-bc/tests/dc_tests.sh
new file mode 100755
index 00000000000..6900ce9098d
--- /dev/null
+++ b/usr.bin/gh-bc/tests/dc_tests.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+unset LC_ALL LC_CTYPE LC_MESSAGES LC_MONETARY LC_NUMERIC LC_TIME
+export LANG=C
+export BC_TEST_OUTPUT_DIR=${PWD}
+exec "$(dirname "$(realpath "$0")")"/tests/all.sh -n dc 1 1 0 0 dc