Make installing to a non-existent directory an error.

Before this, if a file was installed to DESTDIR/some/dir and that directory
was missing due to not having ran 'make distrib-dirs' yet, the file would
be installed as 'some/dir'.  For something like bsd.incs.mk with INCLUDEDIR
being a sub-directory of /usr/include, this could result in all of the headers
being installed to a file rather than getting a directory of them.

Now it will error that the file/directory does not exist rather than hide
the issue.

Another option being discussed is to implement GNU's install -D flag which
would auto create any missing directories.

This is a mitigation of the problem.  The proper order to the build is to
run 'make distrib-dirs' first, but that can be forgotten if building from
a sub-directory after updating the source code to the latest revision.

MFC after:	2 weeks
Sponsored by:	EMC / Isilon Storage Division

This commit is contained in:

Bryan Drewery

2015-10-15 22:49:56 +00:00

parent 7b9c2f1643

commit 61c20fc782

7 changed files with 15 additions and 15 deletions

									
										share/mk/bsd.incs.mk
									
		+1
		-1
	
												View File
												
				@@ -70,7 +70,7 @@ _${group}INS: ${_${group}INCS}

					    ${.ALLSRC} ${DESTDIR}${${group}DIR}/${${group}NAME}

				.else

					${INSTALL} -C -o ${${group}OWN} -g ${${group}GRP} -m ${${group}MODE} \

					    ${.ALLSRC} ${DESTDIR}${${group}DIR}

					    ${.ALLSRC} ${DESTDIR}${${group}DIR}/

				.endif

				.endif