From 5b4f35a4f05aeebf43e9831062746dec6c72a922 Mon Sep 17 00:00:00 2001 From: John Baldwin Date: Sat, 14 May 2011 01:10:57 +0000 Subject: [PATCH] Merge comments about converting directory entries to be more direct and concise. Inspired by: Gleb Kurtsou --- sys/fs/ext2fs/ext2_lookup.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/sys/fs/ext2fs/ext2_lookup.c b/sys/fs/ext2fs/ext2_lookup.c index 5e23b34f209..b293d7ff8ba 100644 --- a/sys/fs/ext2fs/ext2_lookup.c +++ b/sys/fs/ext2fs/ext2_lookup.c @@ -119,17 +119,11 @@ static int ext2_dirbadentry(struct vnode *dp, struct ext2fs_direct_2 *de, /* * Vnode op for reading directories. * - * The routine below assumes that the on-disk format of a directory - * is the same as that defined by . If the on-disk - * format changes, then it will be necessary to do a conversion - * from the on-disk format that read returns to the format defined - * by . - */ -/* - * this is exactly what we do here - the problem is that the conversion - * will blow up some entries by four bytes, so it can't be done in place. - * This is too bad. Right now the conversion is done entry by entry, the - * converted entry is sent via uiomove. + * This function has to convert directory entries from the on-disk + * format to the format defined by . Unfortunately, the + * conversion will blow up some entries by four bytes, so it can't be + * done in place. Instead, the conversion is done entry by entry and + * the converted entry is sent via uiomove. * * XXX allocate a buffer, convert as many entries as possible, then send * the whole buffer to uiomove