KekenoBSD/src
3
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

libnvmf: avoid resource leak

Browse Source 
In nvmf_host_fetch_discovery_log_page(), the log variable may have been
allocated on the heap during the first loop cycle, and should be
free()'d before exiting upon errors.

Reported by:	Coverity
CID:		1545034
Sponsored by:	The FreeBSD Foundation

Reviewed by: imp,jhb
Pull Request: https://github.com/freebsd/freebsd-src/pull/1239
This commit is contained in:
Pierre Pronchery
2024-05-16 16:34:34 +02:00
committed by Warner Losh
parent bd2d71b1c8
commit 408572a24e
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/libnvmf/nvmf_host.c
+5 -1
View File
@@ -653,19 +653,23 @@ nvmf_host_fetch_discovery_log_page(struct nvmf_qpair *qp,
log = NULL; log = NULL;
for (;;) { for (;;) {
error = nvmf_get_discovery_log_page(qp, 0, &hdr, sizeof(hdr)); error = nvmf_get_discovery_log_page(qp, 0, &hdr, sizeof(hdr));
if (error != 0) if (error != 0) {
free(log);
return (error); return (error);
}
nvme_discovery_log_swapbytes(&hdr); nvme_discovery_log_swapbytes(&hdr);
if (hdr.recfmt != 0) { if (hdr.recfmt != 0) {
printf("NVMF: Unsupported discovery log format: %d\n", printf("NVMF: Unsupported discovery log format: %d\n",
hdr.recfmt); hdr.recfmt);
free(log);
return (EINVAL); return (EINVAL);
} }
if (hdr.numrec > 1024) { if (hdr.numrec > 1024) {
printf("NVMF: Too many discovery log entries: %ju\n", printf("NVMF: Too many discovery log entries: %ju\n",
(uintmax_t)hdr.numrec); (uintmax_t)hdr.numrec);
free(log);
return (EFBIG); return (EFBIG);
} }