From 3df5cc33d894edd6b0ae87e51f0e35c3501fb907 Mon Sep 17 00:00:00 2001 From: John Baldwin Date: Thu, 23 Apr 2026 15:16:08 -0400 Subject: [PATCH] ctld: Ports without a portal group are not dummy ports The default implementation of is_dummy should return false. Only portal group ports should possibly return true. PR: 293076 Reported by: Ken J. Thomson Fixes: 6acc7afa34aa ("ctld: Convert struct port to a hierarchy of C++ classes") Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D56524 --- usr.sbin/ctld/ctld.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/ctld/ctld.hh b/usr.sbin/ctld/ctld.hh index 11bda5f25f8..a1bd5a62cf3 100644 --- a/usr.sbin/ctld/ctld.hh +++ b/usr.sbin/ctld/ctld.hh @@ -269,7 +269,7 @@ struct port { virtual struct auth_group *auth_group() const { return nullptr; } virtual struct portal_group *portal_group() const { return nullptr; } - virtual bool is_dummy() const { return true; } + virtual bool is_dummy() const { return false; } virtual void clear_references();