From 30a845609c490c6babe5748d69bff485aeaf0a46 Mon Sep 17 00:00:00 2001 From: Dimitry Andric Date: Sun, 5 Aug 2012 15:55:36 +0000 Subject: [PATCH] In usr.bin/make/var.c, function ParseModifier(), initialize the 'error' variable to NULL, to avoid using it uninitialized in certain cases. This fixes the following clang 3.2 warning: usr.bin/make/var.c:1770:10: error: variable 'error' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if (vp->execute) { ^~~~~~~~~~~ usr.bin/make/var.c:1777:10: note: uninitialized use occurs here if (error) ^~~~~ usr.bin/make/var.c:1770:6: note: remove the 'if' if its condition is always true if (vp->execute) { ^~~~~~~~~~~~~~~~~ usr.bin/make/var.c:1768:23: note: initialize the variable 'error' to silence this warning const char *error; ^ = NULL MFC after: 1 week --- usr.bin/make/var.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.bin/make/var.c b/usr.bin/make/var.c index 477c4a906bc..7cde060f2dd 100644 --- a/usr.bin/make/var.c +++ b/usr.bin/make/var.c @@ -1765,7 +1765,7 @@ ParseModifier(VarParser *vp, char startc, Var *v, Boolean *freeResult) if ((vp->ptr[0] == 's') && (vp->ptr[1] == 'h') && (vp->ptr[2] == endc || vp->ptr[2] == ':')) { - const char *error; + const char *error = NULL; if (vp->execute) { newStr = Buf_Peel(