From 1cebe8a38ebb65bd9bf3f46059b0b0c816780a78 Mon Sep 17 00:00:00 2001 From: Christos Longros <98426896+chrislongros@users.noreply.github.com> Date: Mon, 20 Apr 2026 19:15:29 +0200 Subject: [PATCH] libzfs: report invalid permission name in zfs allow zfs allow with a typo (e.g. "snapshop") produced the misleading error "operation not applicable to datasets of this type". Report "invalid permission" instead. Reviewed-by: Brian Behlendorf Reviewed-by: Tony Hutter Signed-off-by: Christos Longros Closes #18401 Closes #11903 --- lib/libzfs/libzfs_dataset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libzfs/libzfs_dataset.c b/lib/libzfs/libzfs_dataset.c index e5a7ca9ba3f..923bbd995de 100644 --- a/lib/libzfs/libzfs_dataset.c +++ b/lib/libzfs/libzfs_dataset.c @@ -5138,7 +5138,7 @@ zfs_set_fsacl(zfs_handle_t *zhp, boolean_t un, nvlist_t *nvl) err = zfs_error(hdl, EZFS_BADVERSION, errbuf); break; case EINVAL: - err = zfs_error(hdl, EZFS_BADTYPE, errbuf); + err = zfs_error(hdl, EZFS_BADPERM, errbuf); break; case ENOENT: err = zfs_error(hdl, EZFS_NOENT, errbuf);