Make WARNS=6 the default for libexec/.

Just like bin/ and sbin/, I think setting WARNS to the highest value
possible will make it more attractive for people to fix warnings.

- The WARNS variable is set in the Makefile in the directory of the
  application itself, making it more likely that it will be removed out
  of curiosity to see what happens.
- New applications will most likely build with WARNS=6 out of the box,
  because the author would more likely fix the warnings during
  development than lower WARNS.

Unfortunately almost all apps in libexec require a lowered value of
WARNS.
This commit is contained in:
Ed Schouten
2010-01-02 09:50:19 +00:00
parent 3e08d559a8
commit 1100c00131
26 changed files with 41 additions and 10 deletions
+2
View File
@@ -2,4 +2,6 @@
# $FreeBSD$ # $FreeBSD$
BINDIR?= /usr/libexec BINDIR?= /usr/libexec
WARNS?= 6
WFORMAT?= 1 WFORMAT?= 1
+2
View File
@@ -13,6 +13,8 @@ CLEANFILES= ${MAN}
CFLAGS+=-I${MAINSRC} -I${.CURDIR} CFLAGS+=-I${MAINSRC} -I${.CURDIR}
CFLAGS+=-DLOGIN_CAP -DPAM CFLAGS+=-DLOGIN_CAP -DPAM
WARNS?= 2
WFORMAT=0 WFORMAT=0
DPADD= ${LIBPAM} ${LIBUTIL} DPADD= ${LIBPAM} ${LIBUTIL}
+2
View File
@@ -5,6 +5,8 @@ PROG= bootpd
CFLAGS+= -DETC_ETHERS CFLAGS+= -DETC_ETHERS
CFLAGS+= -DSYSLOG -DDEBUG -DVEND_CMU CFLAGS+= -DSYSLOG -DDEBUG -DVEND_CMU
WARNS?= 2
SUBDIR= bootpgw tools SUBDIR= bootpgw tools
SRCS= bootpd.c dovend.c readfile.c hash.c dumptab.c \ SRCS= bootpd.c dovend.c readfile.c hash.c dumptab.c \
+2
View File
@@ -1,3 +1,5 @@
# $FreeBSD$ # $FreeBSD$
BINDIR?= /usr/libexec BINDIR?= /usr/libexec
WARNS?= 1
+2
View File
@@ -2,3 +2,5 @@
# $FreeBSD$ # $FreeBSD$
BINDIR= /usr/sbin BINDIR= /usr/sbin
WARNS?= 1
+1 -1
View File
@@ -5,8 +5,8 @@ PROG= fingerd
DPADD= ${LIBUTIL} DPADD= ${LIBUTIL}
LDADD= -lutil LDADD= -lutil
MAN= fingerd.8 MAN= fingerd.8
WARNS?= 2
WARNS?= 2
WFORMAT=0 WFORMAT=0
.include <bsd.prog.mk> .include <bsd.prog.mk>
+2
View File
@@ -6,6 +6,8 @@ SRCS= main.c init.c subr.c chat.c
DPADD= ${LIBUTIL} DPADD= ${LIBUTIL}
LDADD= -lutil LDADD= -lutil
MAN= gettytab.5 ttys.5 getty.8 MAN= gettytab.5 ttys.5 getty.8
WARNS?= 1
WFORMAT=0 WFORMAT=0
.include <bsd.prog.mk> .include <bsd.prog.mk>
+2
View File
@@ -8,6 +8,8 @@ PROG= mail.local
SRCS= mail.local.c SRCS= mail.local.c
MAN= mail.local.8 MAN= mail.local.8
CFLAGS+=-I${SENDMAIL_DIR}/include -I. CFLAGS+=-I${SENDMAIL_DIR}/include -I.
WARNS?= 2
WFORMAT=0 WFORMAT=0
LIBSMDIR= ${.OBJDIR}/../../lib/libsm LIBSMDIR= ${.OBJDIR}/../../lib/libsm
+2
View File
@@ -5,4 +5,6 @@ SRCS= mknetid.c hash.c parse_group.c
MAN= netid.5 mknetid.8 MAN= netid.5 mknetid.8
WARNS?= 2
.include <bsd.prog.mk> .include <bsd.prog.mk>
+1
View File
@@ -5,6 +5,7 @@ DPADD= ${LIBNETGRAPH}
LDADD= -lnetgraph LDADD= -lnetgraph
MAN= pppoed.8 MAN= pppoed.8
WARNS?= 1
WFORMAT=0 WFORMAT=0
.include <bsd.prog.mk> .include <bsd.prog.mk>
+1
View File
@@ -5,6 +5,7 @@ PROG= rbootd
SRCS= bpf.c conf.c parseconf.c rbootd.c rmpproto.c utils.c SRCS= bpf.c conf.c parseconf.c rbootd.c rmpproto.c utils.c
MAN= rbootd.8 MAN= rbootd.8
WARNS?= 1
WFORMAT=0 WFORMAT=0
.include <bsd.prog.mk> .include <bsd.prog.mk>
+2
View File
@@ -5,4 +5,6 @@ SRCS= revnetgroup.c hash.c parse_netgroup.c
MAN= revnetgroup.8 MAN= revnetgroup.8
WARNS?= 2
.include <bsd.prog.mk> .include <bsd.prog.mk>
-2
View File
@@ -4,8 +4,6 @@ PROG = rpc.rquotad
SRCS = rquotad.c SRCS = rquotad.c
MAN = rpc.rquotad.8 MAN = rpc.rquotad.8
WARNS ?= 6
DPADD= ${LIBRPCSVC} DPADD= ${LIBRPCSVC}
LDADD= -lrpcsvc LDADD= -lrpcsvc
+2
View File
@@ -7,4 +7,6 @@ MAN = rpc.rstatd.8
DPADD= ${LIBRPCSVC} ${LIBUTIL} ${LIBDEVSTAT} DPADD= ${LIBRPCSVC} ${LIBUTIL} ${LIBDEVSTAT}
LDADD= -lrpcsvc -lutil -ldevstat LDADD= -lrpcsvc -lutil -ldevstat
WARNS?= 1
.include <bsd.prog.mk> .include <bsd.prog.mk>
-3
View File
@@ -4,8 +4,6 @@ PROG = rpc.rusersd
SRCS = rusersd.c rusers_proc.c SRCS = rusersd.c rusers_proc.c
MAN = rpc.rusersd.8 MAN = rpc.rusersd.8
WARNS?= 6
DPADD= ${LIBRPCSVC} ${LIBULOG} ${LIBUTIL} DPADD= ${LIBRPCSVC} ${LIBULOG} ${LIBUTIL}
LDADD= -lrpcsvc -lulog -lutil LDADD= -lrpcsvc -lulog -lutil
@@ -14,5 +12,4 @@ LDADD= -lrpcsvc -lulog -lutil
#LDADD+= -L/usr/X11R6/lib -lXext -lX11 #LDADD+= -L/usr/X11R6/lib -lXext -lX11
#.endif #.endif
.include <bsd.prog.mk> .include <bsd.prog.mk>
+2
View File
@@ -7,4 +7,6 @@ MAN = rpc.rwalld.8
DPADD= ${LIBUTIL} DPADD= ${LIBUTIL}
LDADD= -lutil LDADD= -lutil
WARNS?= 2
.include <bsd.prog.mk> .include <bsd.prog.mk>
+2 -1
View File
@@ -7,5 +7,6 @@ MAN = rpc.sprayd.8
DPADD= ${LIBRPCSVC} DPADD= ${LIBRPCSVC}
LDADD= -lrpcsvc LDADD= -lrpcsvc
.include <bsd.prog.mk> WARNS?= 2
.include <bsd.prog.mk>
+1
View File
@@ -4,6 +4,7 @@
PROG= rshd PROG= rshd
MAN= rshd.8 MAN= rshd.8
WARNS?= 3
WFORMAT=0 WFORMAT=0
DPADD= ${LIBUTIL} ${LIBPAM} DPADD= ${LIBUTIL} ${LIBPAM}
+1
View File
@@ -12,6 +12,7 @@ CSTD?= gnu99
CFLAGS+= -Wall -DFREEBSD_ELF -DIN_RTLD CFLAGS+= -Wall -DFREEBSD_ELF -DIN_RTLD
CFLAGS+= -I${.CURDIR}/${MACHINE_ARCH} -I${.CURDIR} CFLAGS+= -I${.CURDIR}/${MACHINE_ARCH} -I${.CURDIR}
LDFLAGS+= -nostdlib -e .rtld_start LDFLAGS+= -nostdlib -e .rtld_start
WARNS?= 2
INSTALLFLAGS= -C -b INSTALLFLAGS= -C -b
PRECIOUSPROG= PRECIOUSPROG=
BINDIR= /libexec BINDIR= /libexec
+2
View File
@@ -15,6 +15,8 @@ LIBSM= ${LIBSMDIR}/libsm.a
DPADD= ${LIBSM} DPADD= ${LIBSM}
LDADD= ${LIBSM} LDADD= ${LIBSM}
WARNS?= 2
SRCS+= sm_os.h SRCS+= sm_os.h
CLEANFILES+=sm_os.h CLEANFILES+=sm_os.h
-1
View File
@@ -7,7 +7,6 @@ SRCS= talkd.c announce.c process.c table.c print.c ttymsg.c
MAN= talkd.8 MAN= talkd.8
CFLAGS+=-I${.CURDIR}/../../usr.bin/wall CFLAGS+=-I${.CURDIR}/../../usr.bin/wall
WARNS?= 6
DPADD= ${LIBULOG} DPADD= ${LIBULOG}
LDADD= -lulog LDADD= -lulog
+2
View File
@@ -18,4 +18,6 @@ CFLAGS+=-DINET6
DPADD= ${LIBWRAP} DPADD= ${LIBWRAP}
LDADD= -lwrap LDADD= -lwrap
WARNS?= 1
.include <bsd.prog.mk> .include <bsd.prog.mk>
+2
View File
@@ -6,4 +6,6 @@ PROG= tftp-proxy
SRCS= tftp-proxy.c filter.c SRCS= tftp-proxy.c filter.c
MAN= tftp-proxy.8 MAN= tftp-proxy.8
WARNS?= 3
.include <bsd.prog.mk> .include <bsd.prog.mk>
+3
View File
@@ -5,7 +5,10 @@ PROG= tftpd
SRCS= tftpd.c tftpsubs.c SRCS= tftpd.c tftpsubs.c
DPADD= ${LIBUTIL} DPADD= ${LIBUTIL}
LDADD= -lutil LDADD= -lutil
WARNS?= 1
WFORMAT=0 WFORMAT=0
MAN= tftpd.8 MAN= tftpd.8
CFLAGS+=-I${.CURDIR}/../../usr.bin/tftp CFLAGS+=-I${.CURDIR}/../../usr.bin/tftp
.PATH: ${.CURDIR}/../../usr.bin/tftp .PATH: ${.CURDIR}/../../usr.bin/tftp
-2
View File
@@ -8,6 +8,4 @@ NO_MAN=
DPADD= ${LIBULOG} DPADD= ${LIBULOG}
LDADD= -lulog LDADD= -lulog
WARNS?= 6
.include <bsd.prog.mk> .include <bsd.prog.mk>
+3
View File
@@ -12,7 +12,10 @@ GENSRCS=yp.h yp_clnt.c ypxfr_clnt.c
MAN= ypxfr.8 MAN= ypxfr.8
CFLAGS+= -I. CFLAGS+= -I.
WARNS?= 2
WFORMAT=0 WFORMAT=0
DPADD= ${LIBRPCSVC} DPADD= ${LIBRPCSVC}
LDADD= -lrpcsvc LDADD= -lrpcsvc