From 0a17b9e03e8402aa912c398e98b48c8b3b4ee232 Mon Sep 17 00:00:00 2001 From: Mateusz Guzik Date: Wed, 3 Apr 2019 20:37:14 +0000 Subject: [PATCH] rctl: fix sysctl kern.racct.enable use after r341182 The value was changed from int to bool. Since the new type is smaller, the rest of the variable in the caller was left unitialized. PR: 236714 Reported by: trasz Diagnosed by: markj Sponsored by: The FreeBSD Foundation --- usr.bin/rctl/rctl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/usr.bin/rctl/rctl.c b/usr.bin/rctl/rctl.c index 74073c13207..5999afe28b1 100644 --- a/usr.bin/rctl/rctl.c +++ b/usr.bin/rctl/rctl.c @@ -378,8 +378,9 @@ print_rules(char *rules, int hflag, int nflag) static void enosys(void) { - int error, racct_enable; size_t racct_enable_len; + int error; + bool racct_enable; racct_enable_len = sizeof(racct_enable); error = sysctlbyname("kern.racct.enable", @@ -392,7 +393,7 @@ enosys(void) err(1, "sysctlbyname"); } - if (racct_enable == 0) + if (!racct_enable) errx(1, "RACCT/RCTL present, but disabled; enable using kern.racct.enable=1 tunable"); }